-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add step for multiple cluster MD devices #425
Conversation
bsc#1235513 jsc#DOCTEAM-1660
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks clear. Nice work, @tahliar !
xml/ha_cluster_md.xml
Outdated
<screen>&prompt.crm.conf;<command>crm configure clone cl-raider1 raider1 meta interleave=true</command> | ||
&prompt.crm.conf;<command>crm configure clone cl-raider2 raider2 meta interleave=true</command> | ||
&prompt.crm.conf;<command>crm configure colocation col-cmd-with-dlm inf: ( cl-raider1 cl-raider2 ) cl-storage</command> | ||
&prompt.crm.conf;<command>crm configure order o-dlm-before-cmd Mandatory: cl-storage ( cl-raider1 cl-raider2 )</command></screen> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only thing is, for the case here with multiple Raid1
instances, the resource group g-storage
would end up having/needing a single resource dlm
, right? @zzhou1?
Practically it's not an issue even if so. But for the constraints in here, would it make more sense to reference the cl-dlm
previously defined in the "DLM" chapter rather than cl-storage
?
I can see the "OCFS2" chapter demonstrates the case with a single Filesystem
instance where the g-storage
from the previous "DLM" chapter is inherited and used:
, and the case with multiple Filesystem
instances where the cl-dlm
from the previous "DLM" chapter is inherited and necessary constraints are used:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you're right, it makes sense to use the non-grouped cl-dlm
for these multi-resource constraints (after all, I added cl-dlm
for precisely this purpose for OCFS2, then promptly forgot about it for cLVM and Cluster MD 😅).
I can change it here and in the cLVM procedure[1] unless Roger objects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for clarification, @tahliar !
For cLVM, lvmlockd
primitive is added to the g-storage
group besides dlm
to be cloned together:
In that case, the procedure seems sensible to use g-storage
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with Yan! Using cl-dlm is more precisely here for Cluster MD.
@gao-yan I've updated the step a bit. Let me know what you think :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good. Thanks, @tahliar !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
* Add step for multiple cluster MD devices bsc#1235513 jsc#DOCTEAM-1660 * Update from tech review
* Add step for multiple cluster MD devices bsc#1235513 jsc#DOCTEAM-1660 * Update from tech review
* Add step for multiple cluster MD devices bsc#1235513 jsc#DOCTEAM-1660 * Update from tech review
* Add step for multiple cluster MD devices bsc#1235513 jsc#DOCTEAM-1660 * Update from tech review
PR creator: Description
Added a step for cloning and adding constraints for multiple cluster MD devices.
PR creator: Are there any relevant issues/feature requests?
PR creator: Which product versions do the changes apply to?
When opening a PR, check all versions of the documentation that your PR applies to.
main
, no backport necessary)PR reviewer only: Have all backports been applied?
The doc team member merging your PR will take care of backporting to older documents.
When opening a PR, do not set the following check box.